x/ibc: stateful clients #6202
x/ibc: stateful clients #6202
Conversation
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been For contributor use:
For admin use:
Thank you for your contribution to the Cosmos-SDK! 🚀 |
| @@ -25,6 +25,7 @@ type ClientState interface { | |||
| // State verification functions | |||
|
|
|||
| VerifyClientConsensusState( | |||
| store sdk.KVStore, | |||
There was a problem hiding this comment.
replaced sdk.Context with KVStore since the client won't be able to access the store thought the context unless we passed the IBC StoreKey as an argument.
This approach is more secure because we can just pass the prefix store for the specific client.
fedekunze
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
hschoenburg,
jgimeno and
nylira
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6202 +/- ##
==========================================
+ Coverage 54.83% 54.84% +0.01%
==========================================
Files 444 444
Lines 26784 26777 -7
==========================================
- Hits 14686 14685 -1
+ Misses 11053 11048 -5
+ Partials 1045 1044 -1 |
| ctx.ChainID(), | ||
| ctx.BlockHeight(), | ||
| ) | ||
| clientState = localhosttypes.NewClientState(ctx.ChainID(), ctx.BlockHeight()) |
There was a problem hiding this comment.
this looks a lot cleaner 🙌 I think it'll be pretty straight forward to create interfaces funcs for clients to implement so we can remove custom client handling here (see #6064)
| @@ -24,6 +26,7 @@ const ( | |||
| type TendermintTestSuite struct { | |||
| suite.Suite | |||
|
|
|||
| ctx sdk.Context | |||
There was a problem hiding this comment.
what was the purpose of adding this?
Description
closes: #6198
cc: @colin-axner